sqlstats: add datadriven tests for sql stats #158157
Open
+291
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
kyle-a-wong
force-pushed
the
sql_stats_ddtests
branch
from
f123352 to
6d67679
Compare
kyle-a-wong
changed the title
kyle-a-wong
force-pushed
the
sql_stats_ddtests
branch
from
6d67679 to
383faa2
Compare
kyle-a-wong
requested review from
angles-n-daemons and
dhartunian
and removed request for
a team
Adds a new datadriven test for sql stats. This datadriven test makes it easy to test expected outputs of sql stats in a deterministic fashion, but not depending on non deterministic fields such as latencies or bytes written. Instead, it simply checks that certain values are greater than 0 or not. The commands on this test support specifying db and app-name args to allow for deterministic results of statement_statistics and transaction_statistics outputs. Epic: None Release note: None
kyle-a-wong
force-pushed
the
sql_stats_ddtests
branch
from
383faa2 to
60785f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new datadriven test for sql stats. This datadriven
test makes it easy to test expected outputs of sql stats
in a deterministic fashion, but not depending on non
deterministic fields such as latencies or bytes written.
Instead, it simply checks that certain values are greater
than 0 or not.
The commands on this test support specifying db
and app-name args to allow for deterministic results of
statement_statistics and transaction_statistics outputs.
Epic: None
Release note: None